summaryrefslogtreecommitdiff
path: root/filters
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2015-11-24 10:28:00 +0000
committerJason A. Donenfeld <Jason@zx2c4.com>2015-11-24 10:31:43 +0000
commit4458abf64172a62b92810c2293450106e6dfc763 (patch)
tree92a3f3587e85c11c77d11769a45d55ddb2fd81a6 /filters
parentffe09621f2626c692a16b249a52112ba8070aa79 (diff)
downloadcgit-4458abf64172a62b92810c2293450106e6dfc763.tar
cgit-4458abf64172a62b92810c2293450106e6dfc763.tar.gz
cgit-4458abf64172a62b92810c2293450106e6dfc763.zip
filter: avoid integer overflow in authenticate_post
ctx.env.content_length is an unsigned int, coming from the CONTENT_LENGTH environment variable, which is parsed by strtoul. The HTTP/1.1 spec says that "any Content-Length greater than or equal to zero is a valid value." By storing this into an int, we potentially overflow it, resulting in the following bounding check failing, leading to a buffer overflow. Reported-by: Erik Cabetas <Erik@cabetas.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'filters')
0 files changed, 0 insertions, 0 deletions