diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2013-04-08 19:12:19 +0000 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2013-04-08 19:43:26 +0000 |
| commit | 8a92df033e974af6338b530a0d78d1bdb0b0f918 (patch) | |
| tree | ea7968f81170a9ed83b50f544036da78b1b8490c /ui-commit.c | |
| parent | fb3655df3bf85bd405c5921bbd4b3a54c705c839 (diff) | |
| download | cgit-8a92df033e974af6338b530a0d78d1bdb0b0f918.tar cgit-8a92df033e974af6338b530a0d78d1bdb0b0f918.tar.gz cgit-8a92df033e974af6338b530a0d78d1bdb0b0f918.zip | |
Do not load user or system gitconfig and gitattributes
While doing any kind of git loading, unset HOME variables and set
NOSYSTEM variables so that cgit does not load any settings that a user
may have set for his own /usr/bin/git usage.
This fixes a fatal error introduced with git 1.8, whereupon git would
fatally exit when failing to access particular files.
The result of this is that only repo-local configuration files are
accessed:
zx2c4@thinkpad ~/Projects/cgit $ HOME=/root QUERY_STRING="url=foo/log"
CGIT_CONFIG=tests/trash/cgitrc strace -e access ./cgit >/dev/null
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
access("repos/foo/.git/objects", X_OK) = 0
access("repos/foo/.git/refs", X_OK) = 0
access("repos/foo/.git/config", R_OK) = 0
access("repos/foo/.git/config", R_OK) = 0
access("repos/foo/.git/objects/b3/bafdbf0183f4897ef8b1319cb8c490ed54717e", F_OK) = 0
access("repos/foo/.git/objects/b3/bafdbf0183f4897ef8b1319cb8c490ed54717e", F_OK) = 0
access("repos/foo/.git/objects/b3/bafdbf0183f4897ef8b1319cb8c490ed54717e", F_OK) = 0
access("repos/foo/.git/objects/b3/bafdbf0183f4897ef8b1319cb8c490ed54717e", F_OK) = 0
+++ exited with 0 +++
Reported-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Tested-by: Jason A. Donenfeld <Jason@zx2c4.com>
Tested-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'ui-commit.c')
| -rw-r--r-- | ui-commit.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ui-commit.c b/ui-commit.c index 6b41017..a5a6ea8 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -37,7 +37,6 @@ void cgit_print_commit(char *hex, const char *prefix) } info = cgit_parse_commit(commit); - init_display_notes(NULL); format_display_notes(sha1, ¬es, PAGE_ENCODING, 0); load_ref_decorations(DECORATE_FULL_REFS); |