From 7f7f91141ced1085dd2c6dbc5c65703d73b1b8c7 Mon Sep 17 00:00:00 2001 From: John Keeping Date: Sun, 15 Jan 2017 12:29:38 +0000 Subject: ui-atom: properly escape delimiter in page link If the delimiter here is '&' then it needs to be escaped for inclusion in an attribute. Use html_attrf() to ensure that this happens (we know that hex won't need escaping, but this makes it clearer what's happening. Signed-off-by: John Keeping --- ui-atom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-atom.c b/ui-atom.c index 41838d3..3866823 100644 --- a/ui-atom.c +++ b/ui-atom.c @@ -63,7 +63,7 @@ static void add_entry(struct commit *commit, const char *host) html_attr(pageurl); if (ctx.cfg.virtual_root) delim = '?'; - htmlf("%cid=%s", delim, hex); + html_attrf("%cid=%s", delim, hex); html("'/>\n"); free(pageurl); } -- cgit v1.2.3-57-g22cb