From ee554849ac7209fa8f7486327ec9f3b370e4c876 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 24 Aug 2009 13:31:49 +0200 Subject: cgit.c: respect repo-local 'snapshots' option for --scan-path The repo-specific 'snapshots' option is bitwise AND'ed with the global 'snapshots' option during parsing, and since the global cgitrc hasn't been parsed when --scan-path is processed the global 'snapshots' will always be 0 (i.e. no repo-specific 'snapshots' setting will have any effect). This patch fixes the issue by setting the global 'snapshots' mask to 0xFF (hence relying on later parsing of the generated cgitrc repolist to do the right thing). Signed-off-by: Lars Hjemli --- cgit.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/cgit.c b/cgit.c index 8381630..3fcca2a 100644 --- a/cgit.c +++ b/cgit.c @@ -620,6 +620,16 @@ static void cgit_parse_args(int argc, const char **argv) } if (!strncmp(argv[i], "--scan-tree=", 12) || !strncmp(argv[i], "--scan-path=", 12)) { + /* HACK: the global snapshot bitmask defines the + * set of allowed snapshot formats, but the config + * file hasn't been parsed yet so the mask is + * currently 0. By setting all bits high before + * scanning we make sure that any in-repo cgitrc + * snapshot setting is respected by scan_tree(). + * BTW: we assume that there'll never be more than + * 255 different snapshot formats supported by cgit... + */ + ctx.cfg.snapshots = 0xFF; scan++; scan_tree(argv[i] + 12, repo_config); } -- cgit v1.2.3-57-g22cb